RE: [PATCH v4 01/50] IB: Add CNP opcode enumeration.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > That is obvious and useless. Patches should have a meaningful
> > > description and justify the changes.
> > >
> >
> > The driver uses the CNP opcode for congestion control.
> 
> And that requires a new transport protocol???
> 

The opcode is 0x80, which appears in the protocol part of the 8 bit opcode.  That is what is specified in A3.10.2 of the 1.3 spec.

That also happens to land in the upper bits of the opcode. 

Would this fit better with a  IB_OPCODE_CNP_TRANS (0x80) with a single opcode of IB_OPCODE_CNP_OP 0x00, combined with the IB_OPCODE macro to produce IB_OPCODE_CNP?

Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux