On 7/30/2015 1:20 PM, Or Gerlitz wrote:
On Thu, Jul 30, 2015 at 11:06 AM, Sagi Grimberg <sagig@xxxxxxxxxxxx> wrote:
We don't update those anywhere in the code and they
seem pretty useless (no one seem to care about those).
qp_tx_queue_full: We never should get this
why?
We reserve slots in our queue-pair based on the maximum inflight IOs.
And we lower the user's cmds_max to our queue-pair size.
So we never get there - also the code never touches this counter.
fmr_map_not_avail: We can never get to this
why? if for some reason fmr pool thread which does unmapping on the
background is slowed/delayed? or the
device firmware/hardware is in troubles?
For FMRs we allocate x2 FMRs to absorb the background unmapping.
Besides, We don't increment this in any place in the code...
I don't see a point in keeping parameters that are not maintained.
Actually I never noticed they were there... a quick git searched didn't
show any usage of those ever.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
