On Thu, Jul 23, 2015 at 01:15:16PM +0300, Sagi Grimberg wrote: > On 7/22/2015 8:44 PM, Jason Gunthorpe wrote: > >On Wed, Jul 22, 2015 at 09:50:12AM -0700, Christoph Hellwig wrote: > >>>+/** > >>>+ * ib_map_mr_sg() - Populates MR with a dma mapped SG list > >>>+ * @mr: memory region > >>>+ * @sg: dma mapped scatterlist > >>>+ * @sg_nents: number of entries in sg > >>>+ * @access: access permissions > >> > >>I know moving the access flags here was my idea originally, but I seem > >>convinced by your argument that it might fit in better with the posting > >>helper. Or did someone else come up with a better argument that mine > >>for moving it here? > > > >I was hoping we'd move the DMA flush and translate into here and make > >it mandatory. Is there any reason not to do that? > > The reason I didn't added it in was so the ULPs can make sure they meet > the restrictions of ib_map_mr_sg(). Allow SRP to iterate on his > SG list set partials and iSER to detect gaps (they need to dma map > for that). I would like to see the kdoc for ib_map_mr_sg explain exactly what is required of the caller, maybe just hoist this bit from the ib_sg_to_pages Not entirely required if we are going to have an API to do the test.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
