Re: [PATCH 6/8] IB/mlx5/hmm: add mlx5 HMM device initialization and callback v3.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17/07/2015 22:01, Jérôme Glisse wrote:
> @@ -151,10 +151,11 @@ int ib_umem_odp_get(struct ib_ucontext *context, struct ib_umem *umem)
>  		context->ib_mirror = ib_mirror_ref(ib_mirror);
>  	}
>  	mutex_unlock(&ib_device->hmm_mutex);
> -	umem->odp_data.ib_mirror = ib_mirror;
> +	umem->odp_data->ib_mirror = ib_mirror;
>  
>  	down_write(&ib_mirror->umem_rwsem);
> -	rbt_ib_umem_insert(&umem->odp_data->interval_tree, &mirror->umem_tree);
> +	rbt_ib_umem_insert(&umem->odp_data->interval_tree,
> +			   &ib_mirror->umem_tree);
>  	up_write(&ib_mirror->umem_rwsem);
>  
>  	mmput(mm);
> @@ -163,7 +164,7 @@ int ib_umem_odp_get(struct ib_ucontext *context, struct ib_umem *umem)
>  
>  void ib_umem_odp_release(struct ib_umem *umem)
>  {
> -	struct ib_mirror *ib_mirror = umem->odp_data;
> +	struct ib_mirror *ib_mirror = umem->odp_data->ib_mirror;
>  
>  	/*
>  	 * Ensure that no more pages are mapped in the umem.

It doesn't look like this code would have compiled before this patch,
and as far as I can see the previous patch removed the #error line.
Could you make sure all of the patches build correctly? You could use
tools/testing/ktest for instance.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux