On Sun, Jul 19, 2015 at 08:33:24AM +0300, Sagi Grimberg wrote: > I was thinking that the user won't explicitly say which key it registers > and it will be decided from the registration itself. > Meaning, the registration code will do: Please don't.. > if (access | (IB_ACCESS_REMOTE_READ | IB_ACCESS_REMOTE_WRITE) > register rkey... > else > register lkey... > > Will that work with iWARP? or will this break because > iWARP needs REMOTE_WRITE for lkeys? Right, it will break. Access flags are only weakly related to lkey/rkey. It needs to be explicit. We have spots in the API that take lkeys and other spots the take rkeys - the caller must always know the intended use of the key it is requesting, there is no reason not to describe that explicitly. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html