Re: [PATCH RFC 1/2] RDMA/iser: limit sg tablesize on device fastreg max depth

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/25/2015 6:39 PM, Steve Wise wrote:
Signed-off-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
Tested-by: Vasu Dev <vasu.dev@xxxxxxxxx>
---
  drivers/infiniband/ulp/iser/iscsi_iser.c |    7 +++++++
  1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c
index 6a594aa..ec692f7 100644
--- a/drivers/infiniband/ulp/iser/iscsi_iser.c
+++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
@@ -640,6 +640,13 @@ iscsi_iser_session_create(struct iscsi_endpoint *ep,
  						   SHOST_DIX_GUARD_CRC);
  		}

+		/*
+		 * Limit the sg_tablesize based on the device max fastreg page
+		 * list length.
+		 */
+		shost->sg_tablesize = min_t(u32, shost->sg_tablesize,
+			ib_conn->device->dev_attr.max_fast_reg_page_list_len);
+
  		if (iscsi_host_add(shost,
  				   ib_conn->device->ib_device->dma_device)) {
  			mutex_unlock(&iser_conn->state_mutex);


This looks good.

Note that I have a patch in the pipe to add support for up to
8MB IO size and there I take into account the device capabilities
(minimum between device capability and user preference).

I was supposed to submit it once the indirect registration support
lands in but given that will take some time, I'll go ahead and send it
out as well.

I have no problem rebasing over this so:

Reviewed-by: Sagi Grimberg <sagig@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux