On Thu, Jun 25, 2015 at 4:52 AM, Weiny, Ira <ira.weiny@xxxxxxxxx> wrote:
> Linus,
>
>>
>> On the *other* side of the same conflict, I find an even more offensive commit,
>> namely commit 4cd7c9479aff ("IB/mad: Add support for additional MAD info
>> to/from drivers") which adds a BUG_ON() for a sanity check, rather than just
>> returning -EINVAL or something sane like that.
>>
>> I'm getting *real* tired of that BUG_ON() shit. I realize that infiniband is a
>> niche market, and those "commercial grade" niche markets are more-than-
>> used-to crap code and horrible hacks, but this is still the kernel. We don't add
>> random machine-killing debug checks when it is *so* simple to just do
>>
>> if (WARN_ON_ONCE(..))
>> return -EINVAL;
>>
>> instead.
>
> Please accept my apologies. The original patch used WARN_ON but I was advised to use BUG_ON in a review and I should have thought about it more rather than blindly make the change.
Ira,
Can you please point me to the review thread where this advise was
made? I can't track it. In internal reviews I always fight with
developers that put BUG_ON assertions whenever something goes wrong,
I'd like to see on what context this feedback was provided to you.
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
