Re: COMMERCIAL: [PATCH] IB/mad: Remove improper use of BUG_ON

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/25/2015 4:50 AM, ira.weiny@xxxxxxxxx wrote:
From: Ira Weiny<ira.weiny@xxxxxxxxx>

commit 97f229a8515f932e5adc6cdfa18cc1440235b9fd
IB/mad: Add support for additional MAD info to/from drivers

added BUG_ON's which were inappropriate for a condition which should never
happen.  Change these to be WARN_ON_ONCE as a debugging aid.

Signed-off-by: Ira Weiny<ira.weiny@xxxxxxxxx>

Ira, you've put the wrong commit id, this isn't the one that appears in Linus tree, also the change-log should be written in a certain way when you fix an earlier commit, see:

We recently added BUG_ON's which were inappropriate for a condition which should
never happen. Change these to be WARN_ON_ONCE as a debugging aid.

Fixes: 4cd7c9479aff ('IB/mad: Add support for additional MAD info to/from drivers')
Signed-off-by: Ira Weiny<ira.weiny@xxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux