> On Thu, Jun 11, 2015 at 01:04:25PM -0400, kaike.wan@xxxxxxxxx wrote: > > +static int acm_nl_parse_path_attr(struct nlattr *attr, > > + struct acm_ep_addr_data *data) > > > + switch (attr->nla_type & NLA_TYPE_MASK) { > > + default: > > + acm_log(1, "WARN: unknown attr %x\n", attr->nla_type); > > + ret = -1; > > + break; > > I would like to see a mandatory/optional scheme here. > > For instance if we add SL it would be mandatory, but policy information like > requesting net_device would be optional. Why would SL be mandatory? Ira -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html