> From: Jason Gunthorpe [mailto:jgunthorpe@xxxxxxxxxxxxxxxxxxxx] > Sent: Thursday, June 11, 2015 2:00 PM > To: Wan, Kaike > Cc: linux-rdma@xxxxxxxxxxxxxxx; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v5 1/1] ibacm: Add support for pathrecord query > through netlink > > On Thu, Jun 11, 2015 at 01:04:25PM -0400, kaike.wan@xxxxxxxxx wrote: > > +static int acm_nl_parse_path_attr(struct nlattr *attr, > > + struct acm_ep_addr_data *data) > > > + switch (attr->nla_type & NLA_TYPE_MASK) { > > + default: > > + acm_log(1, "WARN: unknown attr %x\n", attr->nla_type); > > + ret = -1; > > + break; > > I would like to see a mandatory/optional scheme here. > > For instance if we add SL it would be mandatory, but policy information like > requesting net_device would be optional. > Are you saying the following: 1. all mandatory attributes must be present in the message. Otherwise, the request is invalid. 2. Optional attributes are optional. If they are absent, it is fine. If they are present, they can still be ignored, depending on the application. Then what are the mandatory attributes: sgid, dgid, slid, dlid, pkey, reversise, qos, mtu, rate, or anything related to the pathrecord selection (can be used to set comp_mask during a query)? What are the optional attributes? Kaike -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
