On Tue, Jun 02, 2015 at 07:13:00PM +0300, Matan Barak wrote: > ib_find_cached_gid is used in cm_init_av_by_path. ndev is necessary > in order to find the correct GID in the GID table, as otherwise if two upper > devices has the same IP (hence GID), we might not found the bounded > device correctly. But this is exactly what the current state of affairs is, right? > In addition, vendors need to get the MAC of the ndev that relates to the GID > in order to output a correct Ethernet header. This is currently done though > ib_get_cached_gid. Without adding gid_attr, you get a buggy implementation > that upper devices with different HW addresses would all map to the same MAC. Again, that is current state of affairs, so this change is a bug fix. And, we don't expect macvlan to work today with RDMA, so it isn't even a bug fix, it is a feature add. And.. given the patches I've seen for roce namespaces, I'm not even convinced this is the right API approach. So, save it for the roce namespace support discussion, and we can figure out how to comprehsively deal with multiple netdevs and roce. Otherwise, keep with the current code's assumption that there is on netdev for each roce device. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
