On Thu, May 21, 2015 at 05:11:48PM -0400, Doug Ledford wrote: > fffe in the middle 2 bytes, and then when we call get vf_info, we get a > MAC back that removes those 2 bytes and generates an inconsistency > between what we *think* our constructed guid should be and what the set > guid actually is. Bingo - When ndo_get_vf_config is called on the PF it must return the same 20 byte LLADDR that will match the IFLA_ADDRESS returned on the VF netdevice. If do_get_vf_config returns the 20 byte LLADDR, then ndo_set_vf_mac must also accept the same format. This probably suggests option #2 from my last email is the way to go, as the input and ouput from the set, and any followup IFLA_ADDRESS or ndo_get_vf_config will all be the same LLADDR. Hidden changes to the LLADDR are probably just going to confuse things. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html