On Wed, May 20, 2015 at 04:13:23AM -0400, ira.weiny@xxxxxxxxx wrote: > -struct ib_rmpp_mad { > +struct ib_rmpp_base { > struct ib_mad_hdr mad_hdr; > struct ib_rmpp_hdr rmpp_hdr; > +} __packed; > + > +struct ib_rmpp_mad { > + struct ib_rmpp_base base; > u8 data[IB_MGMT_RMPP_DATA]; > }; Why can't we just use: u8 data[]; And replace various sizeof(ib_rmpp_mad) with a rmpp_payload_size() call? That would make patch 12 alot cleaner Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html