RE: [PATCH 3/3] IB/sa: route SA pathrecord query through netlink

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> >> what's actually the role of the module param? why it belongs here? is
> >> that really unavoidable to have it?
> 
> > It's nice to provide the capability for the user to adjust the netlink timeout
> based his/her fabric setup.
> 
> NO, adding module params should be really your last resort when everything
> else wouldn't work, definitely not the case here, remove it.

Are you suggesting that we use the timeout the caller provides? Or if there is no timeout (0) provided, use a default one? Looking through the IB drivers, I do find many module parameters.
��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux