On Mon, May 04, 2015 at 02:14:55AM -0400, ira.weiny@xxxxxxxxx wrote: > From: Ira Weiny <ira.weiny@xxxxxxxxx> > > Add Core capability flags to each port attribute and read those into ib_device > upon registration for each port. +1 on adding it to read_port_table_lengths But this whole thing is starting to get goofy, 3rd add gets the work to fix it up I guess. Pull pkey_tbl_len, gid_tbl_len and your new thing into a single struct and allocate an array of them. Actually, why not just allocate an array of ib_port_attrs and fill that? Then you can use it for the mad size too. Not in your patch, but why does read_port_table_lengths use a kmalloc for what should be a stack allocation? Yuk. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html