Re: [PATCH v3] IB/core: Fix unaligned accesses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/3/15 4:20 AM, Shachar Raindel wrote:
Hi,

The patch is broken - you did not update

--verbose. I did not update what?


-----Original Message-----
From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma-
owner@xxxxxxxxxxxxxxx] On Behalf Of David Ahern
Sent: Saturday, May 02, 2015 12:22 AM

That is filled in by git and the time on the server is proper. So what do you disagree with?


<snipped>


  static int cm_compare_data(struct ib_cm_compare_data *src_data,
  			   struct ib_cm_compare_data *dst_data)
  {
-	u8 src[IB_CM_COMPARE_SIZE];
-	u8 dst[IB_CM_COMPARE_SIZE];
+	u32 src[IB_CM_COMPARE_SIZE];
+	u32 dst[IB_CM_COMPARE_SIZE];

  	if (!src_data || !dst_data)
  		return 0;
@@ -460,10 +459,10 @@ static int cm_compare_data(struct
ib_cm_compare_data *src_data,
  	return memcmp(src, dst, IB_CM_COMPARE_SIZE);

You added a BUG here - you should use (IB_CM_COMPARE_SIZE * sizeof(u32)).

Thank you for pointing that out. Changed those to sizeof(src) and sizeof(compare_data->mask).


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux