On Fri, May 01, 2015 at 10:33:19AM -0600, David Ahern wrote: > On 5/1/15 10:24 AM, Jason Gunthorpe wrote: > >>- data_cmp = cm_compare_private_data(private_data, > >>+ data_cmp = cm_compare_private_data((u32 *) private_data, > >> cm_id_priv->compare_data); > > > >I'd be happier without this cast, at the worst move it up one more > >layer, at the best, fix the two impacted structures as well. > > I tried to fix private_data and it blows the patch up. Add this: diff --git a/drivers/infiniband/core/cm_msgs.h b/drivers/infiniband/core/cm_msgs.h index be068f47e47e..a1e8cbf0a234 100644 --- a/drivers/infiniband/core/cm_msgs.h +++ b/drivers/infiniband/core/cm_msgs.h @@ -103,7 +103,7 @@ struct cm_req_msg { /* local ACK timeout:5, rsvd:3 */ u8 alt_offset139; - u8 private_data[IB_CM_REQ_PRIVATE_DATA_SIZE]; + u32 private_data[IB_CM_REQ_PRIVATE_DATA_SIZE/4]; } __attribute__ ((packed)); @@ -801,7 +801,7 @@ struct cm_sidr_req_msg { __be16 rsvd; __be64 service_id; - u8 private_data[IB_CM_SIDR_REQ_PRIVATE_DATA_SIZE]; + u32 private_data[IB_CM_SIDR_REQ_PRIVATE_DATA_SIZE/4]; } __attribute__ ((packed)); struct cm_sidr_rep_msg { > >>I feel like I stepped into a tar pit... It's a bit odd that > >>IB_CM_COMPARE_SIZE is part of an enum rather than a #define. > > > >This is, again, idiomatic. '#define CONSTANT' is often frowned upon, > >the semantics of enum are much cleaner/safer, > > '#define NAME VALUE' is used throughout the kernel. Why does ib_rdma > need to be different? There is a mix, the style guide endorses both options. > >To look for more sketchy things that might impact SPARC, ARM, etc. > > Seems like a topic for another patch. Yep Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html