On Thu, Apr 30, 2015 at 07:21:08PM +0000, Hefty, Sean wrote: > > But, how could RDMA CM work? Inbound CM messages will be filtered if > > the IP is not in the HW GID table? > > I'm not understanding the issue. > > If a device has some requirement to program its assigned IP > addresses into some HW table, I don't see why upper layers should be > made to care. Okay, I was only thinking about the first couple patches in this series. Three drivers will have this HW gid table, so having a driver helper library in the common code makes sense to me. But then the series it just seems to go crazy - what is with all these net dev patches? Now we are doing something with bonding? And a lot of screwy looking rocev2 gid type stuff? And driver updates? And 33 patches worth? You are totally right, this GID index and GID type stuff is getting *everywhere*, and it is hard to follow the *why* of all the changes are really needed. Matan, if you want to progress this, then split it up. Make a patch to library the existing roce GID table driver code and update the drivers. Just that bit alone has already spawned a huge discussion. Work the other ancillary unrelated patches in small chuncks through their trees. Then come back to rocev2 with an actual core API proposal patch set that can be discussed. Honestly, I'm not willing to even look at a patch set this big and rambly. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
