On 04/24/2015 05:12 PM, Liran Liss wrote: >> From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma- >> > [snip] >> a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index >> 65994a1..d54f91e 100644 >> --- a/include/rdma/ib_verbs.h >> +++ b/include/rdma/ib_verbs.h >> @@ -75,10 +75,13 @@ enum rdma_node_type { }; >> >> enum rdma_transport_type { >> + /* legacy for users */ >> RDMA_TRANSPORT_IB, >> RDMA_TRANSPORT_IWARP, >> RDMA_TRANSPORT_USNIC, >> - RDMA_TRANSPORT_USNIC_UDP >> + RDMA_TRANSPORT_USNIC_UDP, >> + /* new transport */ >> + RDMA_TRANSPORT_IBOE, > > Remove RDMA_TRANSPORT_IBOE - it is not a transport. > ROCE uses IBTA transport. > > If any code should test for ROCE should invoke a specific helper, e.g., rdma_protocol_iboe(). > This is what you currently call "rdma_tech_iboe" is patch 02/26. > > I think that pretty much everybody agrees that rdma_protocol_*() is a better name than rdma_tech_*(), right? > So, let's change this. Sure, sounds reasonable now, about the IBOE, we still need it to separate the port support IB/ETH without the check on link-layer, So what about a new enum on protocol type? Like: enum rdma_protocol { RDMA_PROTOCOL_IB, RDMA_PROTOCOL_IBOE, RDMA_PROTOCOL_IWARP, RDMA_PROTOCOL_USNIC_UDP }; So we could use query_protocol() to ask device provide the protocol type, and there will be no mixing with the legacy transport type anymore :-) Regards, Michael Wang > > The semantics are: "check that a link supports a certain wire protocol, or a set of wire protocols", where 'certain' > refers to the specific helper... > > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
