On Thu, Mar 26, 2015 at 12:19 AM, Somnath Kotur <somnath.kotur@xxxxxxxxxx> wrote: > From: Matan Barak <matanb@xxxxxxxxxxxx> > > Previously. we used device_mutex lock in order to protect > the device's list. That means that in order to guarantee a > device isn't freed while we use it, we had to lock all > devices. Matan, looking on the cover letter, it says: "[...] Patch 0002 adds a reference count mechanism to IB devices. This mechanism is similar to dev_hold and dev_put available for net devices. This is mandatory for later patches [...]" So in that respect, saying here "Previously. we used device_mutex lock" is a bit cryptic, @ least one typo must exist in this sentence, right? did you want to say "Currently we use device_mutex lock for XXX [...] and this should be replaced as of a YYY change which is to be introduced [...]" please clarify > Adding a kref per IB device. Before an IB device > is unregistered, we wait before its not held anymore. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html