Re: [PATCH 2/2 infiniband-diags] ibqueryerrors: Resource leak in path_record_query

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 21, 2015 at 08:15:12AM -0400, Hal Rosenstock wrote:
> From: Vladimir Koushnir <vladimirk@xxxxxxxxxxxx>
> Date: Thu Apr 16 16:39:43 2015 +0300
>     
> sa_free_handle function is not called at the end of
> path_record_query function.
> The patch fixes file descriptor leak when path_record_query
> function is called.
>     
> Signed-off-by: Vladimir Koushnir <vladimirk@xxxxxxxxxxxx>
> Signed-off-by: Hal Rosenstock <hal@xxxxxxxxxxxx>

Applied Thanks,
Ira

> ---
>  src/ibqueryerrors.c |   34 +++++++++++++++++++++++++++-------
>  1 files changed, 27 insertions(+), 7 deletions(-)
> 
> diff --git a/src/ibqueryerrors.c b/src/ibqueryerrors.c
> index 9d9ec45..8fbb9d1 100644
> --- a/src/ibqueryerrors.c
> +++ b/src/ibqueryerrors.c
> @@ -344,6 +344,7 @@ static int path_record_query(ib_gid_t sgid,uint64_t dguid)
>                          (uint16_t)IB_SA_ATTR_PATHRECORD,0,cl_ntoh64(comp_mask),ibd_sakey,
>                          &pr, sizeof(pr), &result);
>       if (ret) {
> +             sa_free_handle(h);
>               fprintf(stderr, "Query SA failed: %s; sa call path_query failed\n", strerror(ret));
>               return ret;
>       }
> @@ -355,6 +356,7 @@ static int path_record_query(ib_gid_t sgid,uint64_t dguid)
> 
>       insert_lid2sl_table(&result);
>  Exit:
> +     sa_free_handle(h);
>       sa_free_result_mad(&result);
>       return ret;
>  }
> -- 
> 1.7.8.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux