Hi, Steve Thanks for the comment :-) On 04/07/2015 10:16 PM, Steve Wise wrote: [snip] >>> >>> - force_grh = rdma_port_get_link_layer(device, port_num) == IB_LINK_LAYER_ETHERNET; >>> + force_grh = !rdma_transport_ib(device, port_num); >> >> Maybe these tests should be called cap_mandatory_grh - but I'm not >> really sure how iWarp uses the GRH fields in the AH... >> > > iWARP runs on top of TCP...this SA code is all IB-specific. The reason it was checking for ETHERNET, I think, is for RoCE. So > this change is totally incorrect, I think, because RoCE is an IB transport, but it runs on ETHERNET. I guess it's the name 'transport' which confusing folks... actually (!rdma_transport_ib) including RoCE/IBoE, but yes, here it's for IBoE only, so let's change it to rdma_transport_iboe ;-) Regards, Michael Wang > > Steve. > > > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
