> > Rather than calling device->process_mad() directly, would it be better
> to call a common function? So we can avoid adding:
> >
> > > + struct ib_mad *in_mad = (struct ib_mad *)in;
> > > + struct ib_mad *out_mad = (struct ib_mad *)out;
> > > +
> > > + if (in_mad_size != sizeof(*in_mad) || *out_mad_size !=
> > > sizeof(*out_mad))
> > > + return IB_MAD_RESULT_FAILURE;
> >
> > to existing drivers?
>
> No. The checks need to be done by the devices. IB devices expect exactly
> 256
> bytes, OPA devices expect 2K, while some drivers don't care at all (don't
> support MADs).
The checks are per device, but that doesn't mean that every driver has to do the same check.
ib_process_mad(...)
{
if (ib_device(...))
insert check here
else if (opa_device(...))
insert some other check here
else
hit caller on nose
dev->process_mad(...)
}
I'm fine either way. It's more a matter of how much trust is given to the other kernel components.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
