On 11/27/2014 1:47 PM, Or Gerlitz wrote:
On 11/13/2014 9:54 PM, ira.weiny@xxxxxxxxx wrote:
Add a device capability flag for OPA devices to signal their support
of "jumbo"
MADs.
Check for IB_DEVICE_JUMBO_MAD_SUPPORT in the device capabilities and if
supported mark the special QPs created.
Ira,
Few comments here, the device capability is OK, specifically if it helps
for the mad
layer logic to be simpler and/or more robust.
You should add device attribute telling what is the size of MADs
supported by the
device, I think the IBTA mandated 256Band in the OPA case, the driver
will fill there 2k.
You can't just state that (jumbo == 2k) and go to complete design/changes
which use this hard-coded assumption. You need to see how to re-spin
this series
w.o this assumption.
Why do we need both? can't we just rely on just the size?
We're already short on bits in device_cap_flags so maybe we can do
without?
Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
