>
> On Thu, Nov 13, 2014 at 9:54 PM, <ira.weiny@xxxxxxxxx> wrote:
> > The following patch series modifies the kernel MAD processing
> > (ib_mad/ib_umad) and related interfaces to process Intel Omni-Path
> > Architecture MADs on devices which support them.
>
> So this series allows to process such mad when it arrives or goes beyond that
> and allows to send such mad too?
Both send and receive is supported. My apologies for not being clear.
>
> > In addition to supporting some IBTA management classes, OPA devices
> > use MADs with lengths up to 2K. These "jumbo" MADs increase the
> > performance of management traffic.
>
> Can you provide 1-2 use cases where such mads will be sent and by what
> entity? I recall 2KB mads were mentioned over our LWG talks 8 years ago on IB
> routers...
The Intel Omni-Path driver and SM will be the entities using these MADs. The patch series is written such that other devices could use jumbo MAD's but there is no attempt to predict how other technologies would do so.
[snip]
> > [RFC PATCH 07/16] ib/mad: create a jumbo MAD kmem_cache
>
> why not use a single kmem-cache instance with a non hard coded element size,
> 256B (or whatever we use today) or 2KB?
I wanted to be able to adjust the element count of the caches separately to better tune overall memory usage. However, I stopped short of adding additional module parameters to adjust the 2K cache at this time.
>
> Also (nit), please change the prefix for all patches to be IB/mad: and not
> ib/mad: to comply with the existing habit of patch titles for the IB subsystem
I will thanks.
>
> And (another nit), generate patch 0/N using
>
> $ git format-patch --cover-letter
>
> so we have the exact subject line for each patch and the over-all diffstat in the
> cover-letter
I will. My reason for not doing this previously was that I run the git send-email command on generated patches from a different machine than the one on which my repo is located due to Intel's firewall setup. I will clone the repo there and do this in the future.
-- Ira
��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
