Re: [PATCH V1 for-next 1/2] IB/uverbs: Enable device removal when there are active user space applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/18/2014 4:38 PM, Or Gerlitz wrote:
On 11/18/2014 2:11 PM, Yishai Hadas wrote:
@@ -923,6 +1062,7 @@ static void ib_uverbs_add_one(struct ib_device
*device)
      if (device_create_file(uverbs_dev->dev, &dev_attr_abi_version))
          goto err_class;
+    uverbs_dev->disassociated_supported =
device->disassociate_ucontext ? 1 : 0;
      ib_set_client_data(device, &uverbs_client, uverbs_dev);
      return;

please no, for object->yyy_supported flags (here and elsewhere too).

You can add IB device capability (say, named IB_DEVICE_DISASSOCIATE) and
just look it up directly from uverbs throug the IB device pointer
existing in the uverbs device object in the spots you need this (remove
uverbs_dev->disassociated_supported field).


The IB device pointer is not valid at all spots, for example after the HW Device was removed, that's why we set this information on the uverbs device.

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux