> > > > rdma-ndd is a system daemon which watches the procfs hostname file for > updates. > > > > Upon detecting an update it will update the Node Descriptions of the > > RDMA devices in the system. > > What is the effect of this on RoCE and IWARP adapters ? While they populate > node_desc in sysfs, I don't think they support IB_DEVICE_MODIFY_NODE_DESC > for ib_modify_device. No they don't support it. > > Shouldn't such devices be "skipped" in terms of setting NodeDescription ? AFAIK all of the current user space software which write to the node_desc sysfs simply ignore any errors. Those devices which do not support ib_modify_device return EIO from sysfs. This is the same mechanism I used and should be safe. If we want to go down this path[*] I think the core sysfs code should be changed such that the node_desc is either A) not available on those devices or B) not writable if ib_modify_device is not supported. -- Ira [*] Changing this sysfs behavior was not the intent of this patch series and I think should be dealt with separately. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
