On Mon, Nov 03, 2014 at 10:28:25AM +0200, Matan Barak wrote: > On 3/11/2014 4:50 AM, Jason Gunthorpe wrote: > >On Sun, Nov 02, 2014 at 11:30:05AM +0200, Or Gerlitz wrote: > > > >>@@ -886,7 +887,7 @@ struct ibv_context_ops { > >> int (*dealloc_pd)(struct ibv_pd *pd); > >> struct ibv_mr * (*reg_mr)(struct ibv_pd *pd, void *addr, size_t length, > >> int access); > >>- struct ibv_mr * (*rereg_mr)(struct ibv_mr *mr, > >>+ int (*rereg_mr)(struct ibv_mr *mr, > >> int flags, > >> struct ibv_pd *pd, void *addr, > >> size_t length, > > > >What is going on here? > > > >Signatures in the ops structure should not be changed without quite a > >bit more explanation. I'd like to see this in a dedicated patch with a > >proper discussion about why it is safe... > I don't mind re-spin this change into another patch, but since I > don't consider the current state of libibverbs as having memory > re-registration support, I don't think it's necessary. Even so, this changes ABI senstive structures so it needs to be in a dedicated patch and you must include this rational for why it is safe. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html