Re: [PATCH libmlx4] Add MR re-registeration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/2/2014 11:30 AM, Or Gerlitz wrote:
From: Matan Barak <matanb@xxxxxxxxxxxx>

Add memory re-registeration to libmlx4.

Memory re-registeration is a feature that enables one to change
the attributes of a memory region, including PD, translation
(address and length) and access flags.

Signed-off-by: Matan Barak <matanb@xxxxxxxxxxxx>
Signed-off-by: Or Gerlitz <ogerlitz@xxxxxxxxxxxx>
---
  src/mlx4.c  |    1 +
  src/mlx4.h  |    2 ++
  src/verbs.c |   15 +++++++++++++++
  3 files changed, 18 insertions(+), 0 deletions(-)

diff --git a/src/mlx4.c b/src/mlx4.c
index 2999150..115fc9c 100644
--- a/src/mlx4.c
+++ b/src/mlx4.c
@@ -92,6 +92,7 @@ static struct ibv_context_ops mlx4_ctx_ops = {
  	.alloc_pd      = mlx4_alloc_pd,
  	.dealloc_pd    = mlx4_free_pd,
  	.reg_mr	       = mlx4_reg_mr,
+	.rereg_mr      = mlx4_rereg_mr,
  	.dereg_mr      = mlx4_dereg_mr,
  	.create_cq     = mlx4_create_cq,
  	.poll_cq       = mlx4_poll_cq,
diff --git a/src/mlx4.h b/src/mlx4.h
index d71450f..ccb363a 100644
--- a/src/mlx4.h
+++ b/src/mlx4.h
@@ -363,6 +363,8 @@ int mlx4_close_xrcd(struct ibv_xrcd *xrcd);

  struct ibv_mr *mlx4_reg_mr(struct ibv_pd *pd, void *addr,
  			    size_t length, int access);
+int mlx4_rereg_mr(struct ibv_mr *mr, int flags, struct ibv_pd *pd,
+		  void *addr, size_t length, uint64_t access);
  int mlx4_dereg_mr(struct ibv_mr *mr);

  struct ibv_cq *mlx4_create_cq(struct ibv_context *context, int cqe,
diff --git a/src/verbs.c b/src/verbs.c
index 623d576..db97303 100644
--- a/src/verbs.c
+++ b/src/verbs.c
@@ -166,6 +166,21 @@ struct ibv_mr *mlx4_reg_mr(struct ibv_pd *pd, void *addr, size_t length,
  	return mr;
  }

+int mlx4_rereg_mr(struct ibv_mr *mr,
+		  int flags,
+		  struct ibv_pd *pd, void *addr,
+		  size_t length, uint64_t access)
+{
+	struct ibv_rereg_mr cmd;
+	struct ibv_rereg_mr_resp resp;
+
+	return ibv_cmd_rereg_mr(mr, flags, addr, length,
+				(uintptr_t) addr,
+				access, pd,
+				&cmd, sizeof(cmd),
+				&resp, sizeof(resp));
+}
+
  int mlx4_dereg_mr(struct ibv_mr *mr)
  {
  	int ret;


This looks fine to me.

Reviewed-by: Sagi Grimberg <sagig@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux