> + notifiers_seq = atomic_read(&item->odp_data->notifiers_seq) + 1; > + atomic_set(&item->odp_data->notifiers_seq, > + notifiers_seq); Is this code really as silly as it looks, or is there some deep reason for avoiding atomic_inc() that I'm missing? Do you need atomic_inc(), since as far as I can tell all modification of notifiers_seq and notifiers_count happens while holding the umem_mutex? In general I find it very suspicious that you have these two atomic_t members, notifiers_seq and notifiers_count, but you never use anything except atomic_read() and atomic_set() to access them. Why are they atomic_t at all? - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
