Re: [PATCH v2 02/12] blk-mq: Add blk_mq_unique_tag()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/11/14 13:08, Christoph Hellwig wrote:
+static inline u32 blk_mq_build_unique_tag(int hwq, int tag)
+{
+	return (hwq << BLK_MQ_UNIQUE_TAG_BITS) | (tag & BLK_MQ_UNIQUE_TAG_MASK);
+}

Is there any value in having this as a separate helper?

Hello Christoph,

With the approach for block layer tag management proposed in this patch series SCSI LLDs no longer need to call this function. This means that the blk_mq_build_unique_tag() function can be eliminated by inlining it into blk_mq_unique_tag(). Would you like me to rework this patch accordingly ?

Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux