Roland, this patch needs rework. As you pointed out to me, the iSER ULP never arms the SCQ, so iw_cxgb4 should not be trying to notify. Thus even though the patch below resolves the crash, it is not the correct fix. I'll send a new patch that will key on whether the CQs are armed or not. Steve. > -----Original Message----- > From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma-owner@xxxxxxxxxxxxxxx] On > Behalf Of Steve Wise > Sent: Tuesday, July 29, 2014 4:24 PM > To: roland@xxxxxxxxxx > Cc: linux-rdma@xxxxxxxxxxxxxxx > Subject: [PATCH] iw_cxgb4: only call CQ completion handlers if they exist > > The iser ULP creates a CQ without a SQ completion handler, which is valid. > This will cause iw_cxgb4 to crash the system if the QP is flushed. > The fix is to simply not call the handler if the handler ptr is NULL. > > Signed-off-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > --- > > drivers/infiniband/hw/cxgb4/qp.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c > index 086f62f..bdbe6b4 100644 > --- a/drivers/infiniband/hw/cxgb4/qp.c > +++ b/drivers/infiniband/hw/cxgb4/qp.c > @@ -1087,7 +1087,7 @@ static void __flush_qp(struct c4iw_qp *qhp, struct c4iw_cq *rchp, > flushed = c4iw_flush_rq(&qhp->wq, &rchp->cq, count); > spin_unlock(&qhp->lock); > spin_unlock_irqrestore(&rchp->lock, flag); > - if (flushed) { > + if (flushed && rchp->ibcq.comp_handler) { > spin_lock_irqsave(&rchp->comp_handler_lock, flag); > (*rchp->ibcq.comp_handler)(&rchp->ibcq, rchp->ibcq.cq_context); > spin_unlock_irqrestore(&rchp->comp_handler_lock, flag); > @@ -1101,7 +1101,7 @@ static void __flush_qp(struct c4iw_qp *qhp, struct c4iw_cq *rchp, > flushed = c4iw_flush_sq(qhp); > spin_unlock(&qhp->lock); > spin_unlock_irqrestore(&schp->lock, flag); > - if (flushed) { > + if (flushed && schp->ibcq.comp_handler) { > spin_lock_irqsave(&schp->comp_handler_lock, flag); > (*schp->ibcq.comp_handler)(&schp->ibcq, schp->ibcq.cq_context); > spin_unlock_irqrestore(&schp->comp_handler_lock, flag); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
