Hi Or, Is V5 on the cards in the near future? -Regards Devesh > -----Original Message----- > From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma- > owner@xxxxxxxxxxxxxxx] On Behalf Of Or Gerlitz > Sent: Tuesday, May 20, 2014 12:29 PM > To: Jason Gunthorpe > Cc: roland@xxxxxxxxxx; yishaih@xxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; > dledford@xxxxxxxxxx; matanb@xxxxxxxxxxxx > Subject: Re: [PATCH libibverbs V4 0/5] Add support for UD QPs under RoCE IP > addressing > > On 18/05/2014 12:38, Or Gerlitz wrote: > [...] > > changes from V3 -- addressed feedback from Jason: > > - replaced the char* that used to hold the MAC address provided to > > the provider library (e.g libmlx4) with sockaddr_storage and use ARPHRD > > for the af_family (similar to the practice used in the kernel) > > > > - Dropped mask1 from ibv_query_port_ex and put all fields in > comp_mask > > - Added a man page for ibv_query_port_ex > > - Made the code c99 friendly by dropping the anonymous union and > struct > > - Splitted the patches to patch that adds the interface and patch that uses > it > > - Removed the usage of drv_ and lib_ schemas > > - Removed the VERBS_CONTEXT_XXXXXXX > > Hi Jason, so Matan has addressed you comments from V3, could you please > take a look and ack? we find tiny little bug in patch #1 but want to get your > feedback before re-spinning V5. > > Or. > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the > body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at > http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html