RE: [PATCH 3/5] ib/mad: Add pr_notice messages for various umad/mad registration failures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Mon, May 05, 2014 at 09:44:48PM -0400, ira.weiny@xxxxxxxxx wrote:
> > From: Ira Weiny <ira.weiny@xxxxxxxxx>
> 
> An empty commit message is not good enough for the mainline kernel,
> please describe motivation at least.

Will do.

> 
> I am worried about log DOS potential here, it looks like many of these
> messages could be triggered by userspace? Have you thought about this?

Yes I did think about it, see below.

> 
> Generally moving this stuff to a pr_debug might be more appropriate, it is
> very unusual to have logging like this for malformed syscall arguments.

I debated using debug.  The problem with debug is that it requires a kernel recompile.  This may not be acceptable for some users.  Ib_umad devices should  only be accessible from a privileged user which I felt was sufficient protection against a DOS attack.  But if it would be more acceptable I can change to [pr|dev]_debug.

Ira

> 
> Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux