On Mon, May 05, 2014 at 09:44:49PM -0400, ira.weiny@xxxxxxxxx wrote:
> +struct ib_user_mad_reg_req2 {
> + __u32 id;
> + __u32 qpn;
> + __u8 mgmt_class;
> + __u8 mgmt_class_version;
> + __u16 res;
> + __u32 flags;
> + __u64 method_mask[2];
> + __u8 oui[3]; /* network order */
> + __u8 rmpp_version;
> +};
Please make the padding on 64 bit explicit so we don't have weird
problems mixing 32 and 64 bit code.
Similar comment as for userspace using a host order uint for the oui.
It would also be good to verify that a 32 bit binary can successfully
execute the ioctl on a 64 bit kernel.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
