Hi Or, We are having some 200 Odds vendor specific stats to be displayed. With sysfs infrastructure for IB devices we found that each stat will correspond to one file in sysfs tree therefore it will constitute a large number of files in ocrdma tree per port, situation will worsen if SRIOV and Multichannel comes into picture, On the other hand, with debugfs it is possible to have one file displaying multiple stats thus, drastically reducing the number of sysfs file entries. We had a discussion with Roland on this, and he gave us a go-ahead on this as well. However, if you still think we should honor IB-diag infra, we are open to populate IB-compliant stats into that framework as well along with debugfs entries. -Regards Devesh -----Original Message----- From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma-owner@xxxxxxxxxxxxxxx] On Behalf Of Or Gerlitz Sent: Friday, February 07, 2014 2:37 AM To: Devesh Sharma Cc: linux-rdma; Roland Dreier; Selvin Xavier Subject: Re: [PATCH for-next 15/17] RDMA/ocrdma: Support for Skyhawk statistics On Tue, Feb 4, 2014 Devesh Sharma <devesh.sharma@xxxxxxxxxx> wrote: > From: Selvin Xavier <selvin.xavier@xxxxxxxxxx> Issue mailbox command > to get the statistics counters from the skyhawk hardware Reading from the HW the RC transport stats/errors is OK, but there's no justification to display them using debugfs, since the IB core has the infrastructure for you to plugin and get that to user space through the existing sysfs. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
