On Fri, Mar 21, 2025 at 09:59:32AM -0700, Nelson, Shannon wrote:
> diff --git a/drivers/fwctl/pds/main.c b/drivers/fwctl/pds/main.c
> index 6fedde2a962e..e50e1bbdff9a 100644
> --- a/drivers/fwctl/pds/main.c
> +++ b/drivers/fwctl/pds/main.c
> @@ -76,8 +76,7 @@ static int pdsfc_identify(struct pdsfc_dev *pdsfc)
> int err;
>
> ident = dma_alloc_coherent(dev->parent, sizeof(*ident), &ident_pa, GFP_KERNEL);
> - err = dma_mapping_error(dev->parent, ident_pa);
> - if (err) {
> + if (!ident) {
> dev_err(dev, "Failed to map ident buffer\n");
> return err;
x
err is uninitialized, it should just be -ENOMEM I think.
Anyhow I fixed it up, please let me know
Jason
