On 3/7/25 11:53 AM, Shannon Nelson wrote:
> Since there really is no useful return, advertising a return value
> is rather misleading. Make pdsc_auxbus_dev_del() a void function.
>
> Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx>
> Signed-off-by: Shannon Nelson <shannon.nelson@xxxxxxx>
Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> ---
> drivers/net/ethernet/amd/pds_core/auxbus.c | 7 +------
> drivers/net/ethernet/amd/pds_core/core.h | 2 +-
> drivers/net/ethernet/amd/pds_core/devlink.c | 6 ++++--
> 3 files changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/ethernet/amd/pds_core/auxbus.c b/drivers/net/ethernet/amd/pds_core/auxbus.c
> index 2babea110991..78fba368e797 100644
> --- a/drivers/net/ethernet/amd/pds_core/auxbus.c
> +++ b/drivers/net/ethernet/amd/pds_core/auxbus.c
> @@ -175,13 +175,9 @@ static struct pds_auxiliary_dev *pdsc_auxbus_dev_register(struct pdsc *cf,
> return padev;
> }
>
> -int pdsc_auxbus_dev_del(struct pdsc *cf, struct pdsc *pf)
> +void pdsc_auxbus_dev_del(struct pdsc *cf, struct pdsc *pf)
> {
> struct pds_auxiliary_dev *padev;
> - int err = 0;
> -
> - if (!cf)
> - return -ENODEV;
>
> mutex_lock(&pf->config_lock);
>
> @@ -195,7 +191,6 @@ int pdsc_auxbus_dev_del(struct pdsc *cf, struct pdsc *pf)
> pf->vfs[cf->vf_id].padev = NULL;
>
> mutex_unlock(&pf->config_lock);
> - return err;
> }
>
> int pdsc_auxbus_dev_add(struct pdsc *cf, struct pdsc *pf)
> diff --git a/drivers/net/ethernet/amd/pds_core/core.h b/drivers/net/ethernet/amd/pds_core/core.h
> index 14522d6d5f86..631a59cfdd7e 100644
> --- a/drivers/net/ethernet/amd/pds_core/core.h
> +++ b/drivers/net/ethernet/amd/pds_core/core.h
> @@ -304,7 +304,7 @@ int pdsc_register_notify(struct notifier_block *nb);
> void pdsc_unregister_notify(struct notifier_block *nb);
> void pdsc_notify(unsigned long event, void *data);
> int pdsc_auxbus_dev_add(struct pdsc *cf, struct pdsc *pf);
> -int pdsc_auxbus_dev_del(struct pdsc *cf, struct pdsc *pf);
> +void pdsc_auxbus_dev_del(struct pdsc *cf, struct pdsc *pf);
>
> void pdsc_process_adminq(struct pdsc_qcq *qcq);
> void pdsc_work_thread(struct work_struct *work);
> diff --git a/drivers/net/ethernet/amd/pds_core/devlink.c b/drivers/net/ethernet/amd/pds_core/devlink.c
> index 44971e71991f..4e2b92ddef6f 100644
> --- a/drivers/net/ethernet/amd/pds_core/devlink.c
> +++ b/drivers/net/ethernet/amd/pds_core/devlink.c
> @@ -56,8 +56,10 @@ int pdsc_dl_enable_set(struct devlink *dl, u32 id,
> for (vf_id = 0; vf_id < pdsc->num_vfs; vf_id++) {
> struct pdsc *vf = pdsc->vfs[vf_id].vf;
>
> - err = ctx->val.vbool ? pdsc_auxbus_dev_add(vf, pdsc) :
> - pdsc_auxbus_dev_del(vf, pdsc);
> + if (ctx->val.vbool)
> + err = pdsc_auxbus_dev_add(vf, pdsc);
> + else
> + pdsc_auxbus_dev_del(vf, pdsc);
> }
>
> return err;
