On Mon, Mar 10, 2025 at 07:01:56AM +0000, Abhinav Jain wrote: > On Sun, 9 Mar 2025 21:27:51 +0200, Leon Romanovsky wrote: > >On Sun, Mar 09, 2025 at 05:57:31PM +0000, Abhinav Jain wrote: > >> As per the comment, modify ib_device_uevent to publish the node > >> GUID alongside device name, upon device state change. > >> > >> Have compiled the file manually to ensure that it builds. Do not have > >> a readily available IB hardware to test. Confirmed with checkpatch > >> that the patch has no errors/warnings. > > > >I'm missing motivation for this patch. Why is this change needed? > > > >Thanks > > Originally, I was looking at this function in order to solve a syzkaller > bug. I noticed this comment from Jason and I assumed that the motivation > would be to identify the node on which the event is happening. > > With the name, users can identify nodes however Subnet Manager uses > node_guid for discovery and configuration of the nodes. To conclude, I > think just using the node name might not be sufficient for unambiguous > and reliable device management in the network. Up till now, it was sufficient. Let's add new uevent when actual use case will be needed. Thanks
