Re: [PATCH v3 5/6] pds_fwctl: add rpc and query support

[Jason Gunthorpe <jgg@xxxxxxxxxx>]

On Fri, Mar 07, 2025 at 10:53:28AM -0800, Shannon Nelson wrote:

> +#define PDS_FWCTL_RPC_OPCODE_GET_CMD(op)  FIELD_GET(PDS_FWCTL_RPC_OPCODE_CMD_MASK, op)
> +#define PDS_FWCTL_RPC_OPCODE_GET_VER(op)  FIELD_GET(PDS_FWCTL_RPC_OPCODE_VER_MASK, op)

../drivers/fwctl/pds/main.c:302:7: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  302 |                 if (PDS_FWCTL_RPC_OPCODE_CMP(rpc->in.op, op_entry[i].id)) {

Add:

#include <linux/bitfield.h>

Jason