RE: [EXTERNAL] Re: [patch rdma-next v4 1/2] net: mana: Change the function signature of mana_get_primary_netdev_rcu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: RE: [EXTERNAL] Re: [patch rdma-next v4 1/2] net: mana: Change the function signature of mana_get_primary_netdev_rcu
From: Long Li <longli@xxxxxxxxxxxxx>
Date: Wed, 5 Mar 2025 23:29:20 +0000
Accept-language: en-US
Cc: Jason Gunthorpe <jgg@xxxxxxxx>, Leon Romanovsky <leon@xxxxxxxxxx>, Konstantin Taranov <kotaranov@xxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, "linux-rdma@xxxxxxxxxxxxxxx" <linux-rdma@xxxxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-hyperv@xxxxxxxxxxxxxxx" <linux-hyperv@xxxxxxxxxxxxxxx>
In-reply-to: <20250305145604.56855467@kernel.org>
Msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=cb974313-e458-49b6-b152-0f8c4768222d;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2025-03-05T23:25:42Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Tag=10, 3, 0, 1;
References: <1741213360-14567-1-git-send-email-longli@linuxonhyperv.com> <20250305145604.56855467@kernel.org>

> On Wed,  5 Mar 2025 14:22:39 -0800 longli@xxxxxxxxxxxxxxxxx wrote:
> > +	netdev_hold(ndev, NULL, GFP_ATOMIC);
> 
> 😅️
> 
> I asked you to use this API for the tracker functionality, obviously.
> Please don't pass NULL in.

Is it okay to put the tracker in another device? (it's not the same device as the event netdev where netdev_hold() is used)

Sorry I'm not clear about where to put the tracker.

References:
- [patch rdma-next v4 1/2] net: mana: Change the function signature of mana_get_primary_netdev_rcu
  - From: longli
- Re: [patch rdma-next v4 1/2] net: mana: Change the function signature of mana_get_primary_netdev_rcu
  - From: Jakub Kicinski

Prev by Date: RE: [PATCH net] net: mana: Support holes in device list reply msg
Next by Date: Re: [PATCH v2 3/6] pds_core: add new fwctl auxiliary_device
Previous by thread: Re: [patch rdma-next v4 1/2] net: mana: Change the function signature of mana_get_primary_netdev_rcu
Index(es):
- Date
- Thread

[Index of Archives] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Photo] [Yosemite News] [Yosemite Photos] [Linux Kernel] [Linux SCSI] [XFree86]