Re: [PATCH net-next] net/mlnx5: Use generic code for page_pool statistics.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> @@ -276,6 +263,9 @@ static MLX5E_DECLARE_STATS_GRP_OP_FILL_STATS(sw)
>  		mlx5e_ethtool_put_stat(data,
>  				       MLX5E_READ_CTR64_CPU(&priv->stats.sw,
>  							    sw_stats_desc, i));
> +#ifdef CONFIG_PAGE_POOL_STATS
> +	*data = page_pool_ethtool_stats_get(*data, &priv->stats.sw.page_pool_stats);
> +#endif
>  }

Are these #ifdef required? include/net/page_pool/helpers.h:

static inline u64 *page_pool_ethtool_stats_get(u64 *data, const void *stats)
{
	return data;
}

Seems silly to have a stub if it cannot be used.

	Andrew




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux