Re: [PATCH rdma-next 1/6] RDMA/uverbs: Introduce UCAP (User CAPabilities) API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 04, 2025 at 03:44:18PM +0200, Leon Romanovsky wrote:

> > > +	device_initialize(&ucap->dev);
> > > +	ucap->dev.class = &ucaps_class;
> > > +	ucap->dev.devt = MKDEV(MAJOR(ucaps_base_dev), type);
> > > +	ucap->dev.release = ucap_dev_release;
> > > +	dev_set_name(&ucap->dev, ucap_names[type]);
> > 
> > Missing error handling on dev_set_name()
> 
> Most of the kernel users don't check dev_set_name(). It can't fail in
> reality.

I'd still add the missing check

Jason




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux