On 26 Feb 17:25, Jakub Kicinski wrote:
On Wed, 26 Feb 2025 10:49:35 -0800 Saeed Mahameed wrote:On 26 Feb 13:47, Gustavo A. R. Silva wrote: >-struct mlx5e_umr_wqe { >+struct mlx5e_umr_wqe_hdr { > struct mlx5_wqe_ctrl_seg ctrl; > struct mlx5_wqe_umr_ctrl_seg uctrl; > struct mlx5_mkey_seg mkc; >+}; >+ >+struct mlx5e_umr_wqe { >+ struct mlx5e_umr_wqe_hdr hdr; You missed or ignored my comment on v0, anyway: Can we have struct mlx5e_umr_wq_hdr defined anonymously within mlx5e_umr_wqe? Let's avoid namespace pollution.It's also used in struct mlx5e_rq, I don't think it can be anonymous?
Yep, I see now, Thanks!.
