On Wed, Feb 26, 2025 at 12:13 AM Jason Gunthorpe <jgg@xxxxxxxxxx> wrote: > > On Tue, Feb 04, 2025 at 12:21:24AM -0800, Selvin Xavier wrote: > > From: Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx> > > > > The cited comment removed the netdev notifier register call > > from the driver. But, it did not remove the cleanup code from > > the unload path. As a result, driver unload is not clean and > > resulted in undesired behaviour. > > Please don't use vauge generic commit titles: > > RDMA/bnxt_re: Fix issue in the unload path > > Be specific and exact, there are several cases like this in this > series and I'm actively wondering if Linus will object to this for rc > patches. > > RDMA/bnxt_re: Fix missed call to ib_unregister_device() > > Since rdev->nb.notifier_call is always NULL the actual work in > bnxt_re_remove_device() was skipped Sure. will try to be specific in the commit messages in future. thanks > > Jason
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
