On Sun, Feb 23, 2025 at 4:05 PM Tariq Toukan <ttoukan.linux@xxxxxxxxx> wrote:
>
>
>
> On 21/02/2025 10:53, Thorsten Blum wrote:
> > Use secs_to_jiffies() and simplify the code.
> >
> > Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>
> > Reviewed-by: Saeed Mahameed <saeed@xxxxxxxxxx>
> > Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> > ---
> > Resend with "net-next" in the title as suggested by Jacob and Saeed.
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c
> > index 3dbd4efa21a2..19dce1ba512d 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c
> > @@ -220,7 +220,7 @@ static int hws_bwc_queue_poll(struct mlx5hws_context *ctx,
> > bool drain)
> > {
> > unsigned long timeout = jiffies +
> > - msecs_to_jiffies(MLX5HWS_BWC_POLLING_TIMEOUT * MSEC_PER_SEC);
> > + secs_to_jiffies(MLX5HWS_BWC_POLLING_TIMEOUT);
>
> secs_to_jiffies() is expanded to a significantly simpler code than
> msecs_to_jiffies().
>
> LGTM.
>
> Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxx>
>
Reviewed-by: Somnath Kotur <somnath.kotur@xxxxxxxxxxxx>
>
> > struct mlx5hws_flow_op_result comp[MLX5HWS_BWC_MATCHER_REHASH_BURST_TH];
> > u16 burst_th = hws_bwc_get_burst_th(ctx, queue_id);
> > bool got_comp = *pending_rules >= burst_th;
>
>
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
