Re: [PATCH] net/mlx5: Use secs_to_jiffies() instead of msecs_to_jiffies()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 19, 2025 at 03:45:02PM -0800, Jacob Keller wrote:
> 
> 
> On 2/19/2025 12:49 PM, Thorsten Blum wrote:
> > Use secs_to_jiffies() and simplify the code.
> > 
> > Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> 
> nit: this is a cleanup which should have the net-next prefix applied,
> since this doesn't fix any user visible behavior.
> 
> Otherwise, seems like an ok change.

IMHO, completely useless change for old code. I can see a value in new
secs_to_jiffies() function for new code, but not for old code. I want
to believe that people who write kernel patches aware that 1000 msec
equal to 1 sec.

Thanks




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux