On 18/02/2025 2:27, Jakub Kicinski wrote:
On Sat, 15 Feb 2025 19:29:35 +0000 Simon Horman wrote:
+ for_each_set_bit(i, bit_set_ptr, num_bits) {
+ const char *sensor_name = hwmon_get_sensor_name(hwmon, i + bit_set_offset);
+
+ mlx5_core_warn(dev, "Sensor name[%d]: %s\n", i + bit_set_offset, sensor_name);
+ }
+}
nit:
If you have to respin for some other reason, please consider limiting lines
to 80 columns wide or less here and elsewhere in this patch where it
doesn't reduce readability (subjective I know).
+1, please try to catch such situations going forward
Hi Jakub,
This was not missed.
This is not a new thing...
We've been enforcing a max line length of 100 chars in mlx5 driver for
the past few years.
I don't have the full image now, but I'm convinced that this dates back
to an agreement between the mlx5 and netdev maintainers at that time.
80 chars could be too restrictive, especially with today's large
monitors, while 100-chars is still highly readable.
This is subjective of course...
If you don't have a strong preference, we'll keep the current 100 chars
limit. Otherwise, just let me know and we'll start enforcing the
80-chars limit for future patches.
Regards,
Tariq
