On Tue, Feb 11, 2025 at 03:48:51PM -0800, Shannon Nelson wrote:
> Add support for a new fwctl-based auxiliary_device for creating a
> channel for fwctl support into the AMD/Pensando DSC.
>
> Signed-off-by: Shannon Nelson <shannon.nelson@xxxxxxx>
> ---
> drivers/net/ethernet/amd/pds_core/auxbus.c | 3 +--
> drivers/net/ethernet/amd/pds_core/core.c | 7 +++++++
> drivers/net/ethernet/amd/pds_core/core.h | 1 +
> drivers/net/ethernet/amd/pds_core/main.c | 10 ++++++++++
> include/linux/pds/pds_common.h | 2 ++
> 5 files changed, 21 insertions(+), 2 deletions(-)
<...>
My comment is only slightly related to the patch itself, but worth to
write it anyway.
> diff --git a/include/linux/pds/pds_common.h b/include/linux/pds/pds_common.h
> index 5802e1deef24..b193adbe7cc3 100644
> --- a/include/linux/pds/pds_common.h
> +++ b/include/linux/pds/pds_common.h
> @@ -29,6 +29,7 @@ enum pds_core_vif_types {
> PDS_DEV_TYPE_ETH = 3,
> PDS_DEV_TYPE_RDMA = 4,
> PDS_DEV_TYPE_LM = 5,
> + PDS_DEV_TYPE_FWCTL = 6,
This enum and defines below should be cleaned from unsupported types.
I don't see any code for RDMA, LM and ETH.
Thanks
>
> /* new ones added before this line */
> PDS_DEV_TYPE_MAX = 16 /* don't change - used in struct size */
> @@ -40,6 +41,7 @@ enum pds_core_vif_types {
> #define PDS_DEV_TYPE_ETH_STR "Eth"
> #define PDS_DEV_TYPE_RDMA_STR "RDMA"
> #define PDS_DEV_TYPE_LM_STR "LM"
> +#define PDS_DEV_TYPE_FWCTL_STR "fwctl"
>
> #define PDS_VDPA_DEV_NAME PDS_CORE_DRV_NAME "." PDS_DEV_TYPE_VDPA_STR
> #define PDS_VFIO_LM_DEV_NAME PDS_CORE_DRV_NAME "." PDS_DEV_TYPE_LM_STR "." PDS_DEV_TYPE_VFIO_STR
> --
> 2.17.1
>
>
