Re: [PATCH for-next] RDMA/core: Fix best page size finding when it can cross SG entries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2/16/2025 10:07 AM, Leon Romanovsky wrote:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



On Thu, Feb 13, 2025 at 02:12:42PM -0400, Jason Gunthorpe wrote:
On Thu, Feb 13, 2025 at 07:55:17PM +0200, Leon Romanovsky wrote:
On Thu, Feb 13, 2025 at 01:40:43PM -0400, Jason Gunthorpe wrote:
On Thu, Feb 13, 2025 at 07:35:10PM +0200, Leon Romanovsky wrote:

Initially curr_base is 0xFF.....FF and curr_len is 0.
curr base can't be so unaligned can it?
It is only for first iteration where it is compared with
sg_dma_address(), immediately after that it is overwritten.
But this is all working with inherently page aligned stuff, cur_base +
len1 + len2 + len3 + len_n should be page aligned for interior segments..
This is unknown to static code analyze tools. I'm not concerned about
logical change, but about possible static code analyze failures.

Thanks

OK, I'll edit the patch to make sure it doesn't produce any SA failures.

Michael





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux